fix(solid-query): add useQuery, useInfiniteQuery, useQueries, useMutation as alternative (primary) syntax to align with react and ease maintenance
#8938
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iteQuery`, `useQueries`, `useMutation` like react to ease maintenance. Add alias to createX for backwards compat.
github-actions
bot
added
package: solid-query
package: solid-query-persist-client
labels
|
View your CI Pipeline Execution ↗ for commit fcd5508.
☁️ Nx Cloud last updated this comment at |
|
Sizes for commit fcd5508:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8938 +/- ##
===========================================
+ Coverage 44.07% 79.45% +35.38%
===========================================
Files 200 15 -185
Lines 8021 331 -7690
Branches 1761 63 -1698
===========================================
- Hits 3535 263 -3272
+ Misses 4058 56 -4002
+ Partials 428 12 -416
🚀 New features to boost your workflow:
|
birkskyum
changed the title
createX syntax to useQuery, useInfiniteQuery, useQueries, useMutation like react to ease maintenance. Add alias to createX for backwards compat.useQuery, useInfiniteQuery, useQueries, useMutation syntax to align with react and ease maintenance
birkskyum
changed the title
useQuery, useInfiniteQuery, useQueries, useMutation syntax to align with react and ease maintenanceuseQuery, useInfiniteQuery, useQueries, useMutation as alternative syntax to align with react and ease maintenance
birkskyum
changed the title
useQuery, useInfiniteQuery, useQueries, useMutation as alternative syntax to align with react and ease maintenanceuseQuery, useInfiniteQuery, useQueries, useMutation as alternative (main) syntax to align with react and ease maintenance
birkskyum
changed the title
useQuery, useInfiniteQuery, useQueries, useMutation as alternative (main) syntax to align with react and ease maintenanceuseQuery, useInfiniteQuery, useQueries, useMutation as alternative (primary) syntax to align with react and ease maintenance
birkskyum
deleted the
move-solid-to-useQuery-syntax-for-easier-maintenance
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to
Rename (and add alias for backwards compat):
createQuery->useQuerycreateInfiniteQuery->useInfiniteQuerycreateQueries->useQueriescreateMutation->useMutationThis is done, because having same API surface and file structure makes it much easier to sync the solid adapter to the react adapter, and it makes no difference to solid devs.