Skip to content

fix(solid-query): use DefaultError type on error inqueryOptions #8472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 24, 2024
Merged

fix(solid-query): use DefaultError type on error inqueryOptions #8472

merged 1 commit into from
Dec 24, 2024

Conversation

@milhamm
Copy link
Contributor

@milhamm milhamm commented Dec 24, 2024

Fix #8460

Resolve the erased error type when using queryOptions by changing the default TError to DefaultError instead of unknown

@milhamm milhamm changed the title fix(solid-query): use DefaultError type on error when using queryOptions fix(solid-query): use DefaultError type on error inqueryOptions Dec 24, 2024
@TkDodo TkDodo merged commit 287848b into TanStack:main Dec 24, 2024
1 check passed
@milhamm milhamm deleted the fix/solid-query-options-error-types branch December 24, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TkDodo TkDodo TkDodo approved these changes

Assignees

No one assigned

Labels

package: solid-query

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[solid-query] queryOptions() erases error type

2 participants

@milhamm @TkDodo