Skip to content

fix(core): do not inform QueriesObserver subscribers if combined result hasn't changed #8153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 9, 2024
Merged

fix(core): do not inform QueriesObserver subscribers if combined result hasn't changed #8153

merged 1 commit into from
Oct 9, 2024

Conversation

@TkDodo
Copy link
Collaborator

@TkDodo TkDodo commented Oct 9, 2024

fixes #8122

@nx-cloud
Copy link

nx-cloud bot commented Oct 9, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit f6fdbe2. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Oct 9, 2024

Open in Stackblitz

More templates

@tanstack/angular-query-experimental

pnpm add https://pkg.pr.new/@tanstack/angular-query-experimental@8153

@tanstack/eslint-plugin-query

pnpm add https://pkg.pr.new/@tanstack/eslint-plugin-query@8153

@tanstack/query-async-storage-persister

pnpm add https://pkg.pr.new/@tanstack/query-async-storage-persister@8153

@tanstack/query-broadcast-client-experimental

pnpm add https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@8153

@tanstack/query-core

pnpm add https://pkg.pr.new/@tanstack/query-core@8153

@tanstack/query-devtools

pnpm add https://pkg.pr.new/@tanstack/query-devtools@8153

@tanstack/query-sync-storage-persister

pnpm add https://pkg.pr.new/@tanstack/query-sync-storage-persister@8153

@tanstack/query-persist-client-core

pnpm add https://pkg.pr.new/@tanstack/query-persist-client-core@8153

@tanstack/react-query

pnpm add https://pkg.pr.new/@tanstack/react-query@8153

@tanstack/react-query-devtools

pnpm add https://pkg.pr.new/@tanstack/react-query-devtools@8153

@tanstack/react-query-next-experimental

pnpm add https://pkg.pr.new/@tanstack/react-query-next-experimental@8153

@tanstack/react-query-persist-client

pnpm add https://pkg.pr.new/@tanstack/react-query-persist-client@8153

@tanstack/solid-query

pnpm add https://pkg.pr.new/@tanstack/solid-query@8153

@tanstack/solid-query-devtools

pnpm add https://pkg.pr.new/@tanstack/solid-query-devtools@8153

@tanstack/solid-query-persist-client

pnpm add https://pkg.pr.new/@tanstack/solid-query-persist-client@8153

@tanstack/svelte-query-devtools

pnpm add https://pkg.pr.new/@tanstack/svelte-query-devtools@8153

@tanstack/svelte-query

pnpm add https://pkg.pr.new/@tanstack/svelte-query@8153

@tanstack/svelte-query-persist-client

pnpm add https://pkg.pr.new/@tanstack/svelte-query-persist-client@8153

@tanstack/vue-query

pnpm add https://pkg.pr.new/@tanstack/vue-query@8153

@tanstack/vue-query-devtools

pnpm add https://pkg.pr.new/@tanstack/vue-query-devtools@8153

@tanstack/angular-query-devtools-experimental

pnpm add https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@8153

commit: f6fdbe2

joel-narwhal
joel-narwhal reviewed Oct 9, 2024
View reviewed changes
packages/query-core/src/queriesObserver.ts
client: QueryClient,
queries: Array<QueryObserverOptions<any, any, any, any, any>>,
_options?: QueriesObserverOptions<TCombinedResult>,
options?: QueriesObserverOptions<TCombinedResult>,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it safe to rely on this? If options.combine change in the hook, will this be reflected?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes because we update it here:

query/packages/query-core/src/queriesObserver.ts

Line 92 in f6fdbe2

this.#options = options

@codecov
Copy link

codecov bot commented Oct 9, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.14%. Comparing base (2fe16e5) to head (f6fdbe2).
Report is 8 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #8153       +/-   ##
===========================================
+ Coverage   45.41%   62.14%   +16.72%     
===========================================
  Files         200      136       -64     
  Lines        7456     4765     -2691     
  Branches     1696     1331      -365     
===========================================
- Hits         3386     2961      -425     
+ Misses       3694     1564     -2130     
+ Partials      376      240      -136
Components Coverage Δ
@tanstack/angular-query-devtools-experimental ∅ <ø> (∅)
@tanstack/angular-query-experimental 86.58% <ø> (ø)
@tanstack/eslint-plugin-query ∅ <ø> (∅)
@tanstack/query-async-storage-persister 43.85% <ø> (ø)
@tanstack/query-broadcast-client-experimental ∅ <ø> (∅)
@tanstack/query-codemods ∅ <ø> (∅)
@tanstack/query-core 93.15% <100.00%> (+0.14%) ⬆️
@tanstack/query-devtools 4.79% <ø> (ø)
@tanstack/query-persist-client-core 57.73% <ø> (ø)
@tanstack/query-sync-storage-persister 82.50% <ø> (ø)
@tanstack/react-query 93.12% <100.00%> (ø)
@tanstack/react-query-devtools 10.00% <ø> (ø)
@tanstack/react-query-next-experimental ∅ <ø> (∅)
@tanstack/react-query-persist-client 100.00% <ø> (ø)
@tanstack/solid-query 78.20% <ø> (ø)
@tanstack/solid-query-devtools ∅ <ø> (∅)
@tanstack/solid-query-persist-client 100.00% <ø> (ø)
@tanstack/svelte-query 87.33% <ø> (ø)
@tanstack/svelte-query-devtools ∅ <ø> (∅)
@tanstack/svelte-query-persist-client 100.00% <ø> (ø)
@tanstack/vue-query 71.51% <ø> (ø)
@tanstack/vue-query-devtools ∅ <ø> (∅)

@TkDodo TkDodo merged commit cae2524 into main Oct 9, 2024
8 checks passed
@TkDodo TkDodo deleted the feature/useQueries-re-render branch October 9, 2024 12:57
This was referenced Oct 31, 2024
Closed
Closed
Merged
@muhiddinjv muhiddinjv mentioned this pull request Oct 31, 2024
Closed
@Bancha-t Bancha-t mentioned this pull request Oct 31, 2024
Open
@Bonniemarie216 Bonniemarie216 mentioned this pull request Oct 31, 2024
Open
This was referenced Nov 2, 2024
Closed
Closed
@jwinr jwinr mentioned this pull request Nov 4, 2024
Merged
@CalPinSW CalPinSW mentioned this pull request Nov 5, 2024
Merged
@GouravNG GouravNG mentioned this pull request Nov 5, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@joel-narwhal joel-narwhal joel-narwhal left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

package: query-core package: react-query

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@TkDodo @joel-narwhal