Skip to content

[WIP] repro hydrate() causes unhandled promise rejection with a throwing prefetchQuery #7867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[WIP] repro hydrate() causes unhandled promise rejection with a throwing prefetchQuery #7867

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/react-query/src/__tests__/useQuery.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6581,6 +6581,7 @@ describe('useQuery', () => {
defaultOptions: { hydrate: { queries: { retry: 1, retryDelay: 10 } } },
})
hydrate(clientQueryClient, dehydrated)
await sleep(400)
Copy link
Collaborator

@Ephem Ephem Jan 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is causing the fetch to fail before rendering, which means the client can immediately retry on rendering, putting the query in a fetching state, so the redacted will never get printed to the DOM.

If you instead inspect the queryCache directly, it's there.
If you instead put the await between the two waitFor below, the test succeeds again.

So while this might have surfaced an unhandled error in the past, the actual test fail seems to be unrelated.


const rendered = renderWithClient(clientQueryClient, <Page />)
await waitFor(() => rendered.getByText('failure: redacted'))
Expand Down