-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Remove overloads #4714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Remove overloads #4714
Changes from all commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
cca39d0
refactor(query-core): remove overloads
Mamoanwar97 797f2fa
test(query-core): apply single signature to all tests
Mamoanwar97 54cc996
refactor(react-query): remove overloads
Mamoanwar97 dd89050
test(react-query): apply single signature to all tests
Mamoanwar97 85b6824
refactor(solid-query): remove overloads
Mamoanwar97 184020e
test(solid-query): apply single signature to all tests
Mamoanwar97 7bff740
refactor(vue-query): remove overloads
Mamoanwar97 120635a
test(vue-query): apply single signature to all tests
Mamoanwar97 931d2d0
test(react-query-persist-client): apply single signature to all tests
Mamoanwar97 d60536f
fix(react-query-devtools): apply single signature to all tests
Mamoanwar97 055483e
test(react-query-devtools): apply single signature to all tests
Mamoanwar97 eea1f8b
test(query-sync-storage-persister): apply single signature to all tests
Mamoanwar97 66f9dfa
docs: apply object single signature to all docs
Mamoanwar97 9d8cd72
Merge branch 'v5' of https://github.com/TanStack/query into remove-ov…
Mamoanwar97 c5cc3c2
docs(examples/react): apply object single signature to all examples
Mamoanwar97 e3c2fbf
docs(examples/solid): apply object single signature to all examples
Mamoanwar97 41a651a
docs(examples/vue): apply object single signature to all examples
Mamoanwar97 8568e13
style(examples): run prettier on all files
Mamoanwar97 807c106
docs: use multiline whenever we use the object syntax
Mamoanwar97 8a9ae6e
fix(setQueryDefaults): keep it as two arguments
Mamoanwar97 6630273
fix(createMutation): remove unnecessary shallow copy
Mamoanwar97 3ffc6ab
fix(vue-query): rename parseArgs functions to unrefArgs
Mamoanwar97 fcd30e1
docs(migrating-to-react-query-5): list all affected functions
Mamoanwar97 3346d5a
fix(setQueryData): remove as alias
Mamoanwar97 cd4a3ae
refactor(getQueryData): getQueryData now supports only queryKey as an…
Mamoanwar97 c865325
refactor(getQueryState): getQueryState now supports only queryKey as …
Mamoanwar97 556aedd
test(react-query/useQuery): missing single signature
Mamoanwar97 7534b46
Merge branch 'v5' into remove-overloads
Mamoanwar97 2bf7484
Merge branch 'v5' of https://github.com/TanStack/query into remove-ov…
Mamoanwar97 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this workaround is also unnecessary without the overloads. @ardeora can you have a look please