-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
fix(react-query-devtools): support cjs in noop build #3884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 9bd505f:
|
|
Do we need your PR, the other PR, or both? |
|
Your PR actually looks more complete, thank you 🙏 |
|
Yes. The other PR pointed out the issue but doesn't export for noop actually. This PR should fix them all. |
|
Thank you very much 🙇♂️ |
|
@songkeys could it be that we point to the wrong direction for the default require exports. It points towards: but looking at the build directory when I create a build locally,
so it's not inside the src directory... |
|
@TkDodo Oops. I'm sorry about this. You are right. Is it a fix yet? Or do you want me to submit another PR? |
|
another PR would be great, thanks |
Just noticed that someone also made a PR #3883 . But we should export the noop version.