Update CachedQuery to add type to state member #386
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No. The DT types need to be deprecated tbh |
|
View your CI Pipeline Execution ↗ for commit f24c309
☁️ Nx Cloud last updated this comment at |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While using the
queryCache.refetchQueriesmethod with a predicate, I noticed that thequery.statewas typed asunknown. This blocks retrieval of thedatamember ofstate.I have added types to the
statemember,CachedQueryState<T>. I decided to make it generic in order to be able to constrain the type fordata- however, it could also beanyjust as easily.Should this be backported back to DefinitelyTyped?