useInfiniteQuery's implementation disregards falsy nextCursor value

[DennisOluoch]

How useInfiteQuery hook was designed to function is that when getFetchMore queries for data and nextCursor/nextId/nexPage/cursor (or whatever the name you give) returns a falsy value or no value at all then the function (getFetchMore) should abort querying for next data otherwise we'll start from beginning which will cause unwanted duplication. However, that's not the case. getFetchMore disregards the falsy value and goes ahead to query data. So we end up with a query like for example:- /api/projects?cursor=null which returns duplicate data.

To Reproduce
Steps to reproduce the behavior:

1. Run load-more-infinite-scroll example from react-query's examples directory
2. I'm running v2.5.1 of react-query but the bug should suffice in v2 and above

Expected behavior
useInfinteQuery should abort fetching data when nextId/nexCursor/nextPage is null

Additional context
If it's not a bug then maybe the implementation changed a great deal that we are not aware of

[tannerlinsley]

I've updated the example to reflect actual intended usage. The way it works is that canFetchMore is the result of getFetchMore, and the example wasn't using canFetchMore to turn off the intersectionObserver :( It does now though and all is well!

[tannerlinsley]

🎉 This issue has been resolved in version 3.0.1 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[DennisOluoch]

Thank you for the quick response. Cheers!