Propagate mutation meta to default onError handler (from defaultOptions.mutations)

[rodion-optifino]

In global error handler (from mutationCache.config.onError) it is possible to access mutation meta as 4th argument but in default error handler (from defaultOptions.mutations) there is no access to mutation meta which seems strange to me.
My use case is to provide human-readable title for errors that handled in a general way and I want to use mutation meta to do so.

Same applies to useMutation onError and mutate onError, is there something that doesn't allow to receive mutation meta here?

[TkDodo]

the 4th argument isn’t meta, it’s the mutation instance itself, which has a .meta field.

The defaultOptions are observer options - the same ones you pass to useMutation, and there, we also don’t pass the mutation itself.

My use case is to provide human-readable title for errors that handled in a general way and I want to use mutation meta to do so.

It’s probably best to do this in the global error handler.

[rodion-optifino]

we also don’t pass the mutation itself

Is it due to technical restrictions or architectural design?

[TkDodo]

I don’t think it was necessary / nobody wanted to have this 🤷

but for other errors I want to have default handler (to show toast) which will be ignored when I provide local handler.

I’ve usually seen this to become a footgun when people add an error handler locally to rollback an optimistic update or to do some error logging, which would then overwrite the toasts. In which case do you want to disable showing a toast for an error that you would usually show an error for? Opting out via meta: { errors: 'none' } or something is usually fine

[rodion-optifino]

In cases when error can be shown on page (in most cases it is form) I would prefer showing error on page and disable toast.

So instead of using default error handler (in defaultOptions.mutations) you recommend implementing this logic in global handler and using meta: { errors: 'none' } or meta: { skipDefaultErrorHandling: true } to disable toast if needed?

[TkDodo]

yes, or you make it opt-in with meta: { errors: 'myErrorMessage' }. If you're 50:50 between wanting an error toast and not wanting it, I'd suggest not doing global handling at all.

[rodion-optifino]

Thank you for your answer.

In my case I'm going with errors?: 'all' | 'skip default' | 'skip all' in meta.