-
Notifications
You must be signed in to change notification settings - Fork 104
Add createOptimisticAction helper that replaces useOptimisticMutation #210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 5fff068 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@tanstack/db-example-react-todo
commit: |
Size Change: +317 B (+1.11%) Total Size: 29 kB
ℹ️ View Unchanged
|
Size Change: 0 B Total Size: 822 B ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love it - so much cleaner
I was about to say we need to delete the useOptimisticQuery react and view tests... but we didn't have any 😂
If you don't write any tests you don't have to delete them! |
fixes #202
An example of converting a
useOptimisticMutation
hook tocreateOptimisticAction
. Now all optimistic & server mutation logic are consolidated.