Skip to content

API-based versioning #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 12, 2024
Merged

API-based versioning #65

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions Packages/com.trytalo.talo/Runtime/EventsAPI.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ public class EventsAPI : BaseAPI
private List<Event> queue = new List<Event>();
private readonly int minQueueSize = 10;

public EventsAPI(TaloManager manager) : base(manager, "events") { }
public EventsAPI(TaloManager manager) : base(manager, "/v1/events") { }

private string GetWindowMode()
{
Expand Down Expand Up @@ -51,9 +51,9 @@ public async Task Track(string name, params (string, string)[] props)
{
Talo.IdentityCheck();

var ev = new Event
{
name = name
var ev = new Event
{
name = name
};

if (props != null)
Expand Down
2 changes: 1 addition & 1 deletion Packages/com.trytalo.talo/Runtime/GameConfigAPI.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ public class GameConfigAPI : BaseAPI
{
public event Action<LiveConfig> OnLiveConfigLoaded;

public GameConfigAPI(TaloManager manager) : base(manager, "game-config") { }
public GameConfigAPI(TaloManager manager) : base(manager, "/v1/game-config") { }

public async Task Get()
{
Expand Down
2 changes: 1 addition & 1 deletion Packages/com.trytalo.talo/Runtime/LeaderboardsAPI.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ namespace TaloGameServices
{
public class LeaderboardsAPI : BaseAPI
{
public LeaderboardsAPI(TaloManager manager) : base(manager, "leaderboards") { }
public LeaderboardsAPI(TaloManager manager) : base(manager, "/v1/leaderboards") { }

public async Task<LeaderboardEntriesResponse> GetEntries(string internalName, int page)
{
Expand Down
4 changes: 2 additions & 2 deletions Packages/com.trytalo.talo/Runtime/PlayersAPI.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,9 @@ namespace TaloGameServices
{
public class PlayersAPI : BaseAPI
{
public event Action<Player> OnIdentified;
public event Action<Player> OnIdentified;

public PlayersAPI(TaloManager manager) : base(manager, "players") { }
public PlayersAPI(TaloManager manager) : base(manager, "/v1/players") { }

public async Task Identify(string service, string identifier)
{
Expand Down
2 changes: 1 addition & 1 deletion Packages/com.trytalo.talo/Runtime/SavesAPI.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ public GameSave Current
get => _currentSave;
}

public SavesAPI(TaloManager manager) : base(manager, "game-saves") {
public SavesAPI(TaloManager manager) : base(manager, "/v1/game-saves") {
_fileHandler = Talo.TestMode
? new SavesTestFileHandler()
: new SavesFileHandler();
Expand Down
2 changes: 1 addition & 1 deletion Packages/com.trytalo.talo/Runtime/StatsAPI.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ namespace TaloGameServices
{
public class StatsAPI : BaseAPI
{
public StatsAPI(TaloManager manager) : base(manager, "game-stats") { }
public StatsAPI(TaloManager manager) : base(manager, "/v1/game-stats") { }

public async Task Track(string internalName, float change = 1f)
{
Expand Down
2 changes: 1 addition & 1 deletion Packages/com.trytalo.talo/Runtime/TaloSettings.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ namespace TaloGameServices
public class TaloSettings : ScriptableObject
{
public string accessKey;
public string apiUrl = "https://api.trytalo.com/v1";
public string apiUrl = "https://api.trytalo.com";
[Tooltip("How often in seconds events are flushed in a WebGL build, see the docs for more info")]
public float webGLEventFlushRate = 30f;
}
Expand Down