Skip to content

Unify responses from GetEntries and GetEntriesForCurrentPlayer #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 12, 2024
Merged

Unify responses from GetEntries and GetEntriesForCurrentPlayer #63

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions Packages/com.trytalo.talo/Runtime/LeaderboardsAPI.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,16 +17,15 @@ public async Task<LeaderboardEntriesResponse> GetEntries(string internalName, in
return res;
}

public async Task<LeaderboardEntry[]> GetEntriesForCurrentPlayer(string leaderboardInternalName, int page)
public async Task<LeaderboardEntriesResponse> GetEntriesForCurrentPlayer(string internalName, int page)
{
Talo.IdentityCheck();

var uri = new Uri(baseUrl + $"/{leaderboardInternalName}/entries?page={page}&aliasId={Talo.CurrentAlias.id}");
var uri = new Uri(baseUrl + $"/{internalName}/entries?page={page}&aliasId={Talo.CurrentAlias.id}");

var json = await Call(uri, "GET");
var res = JsonUtility.FromJson<LeaderboardEntriesResponse>(json);

return res.entries;
return res;
}

public async Task<(LeaderboardEntry, bool)> AddEntry(string internalName, float score)
Expand Down