Handle empty LiveConfig array + add tests

Packages/com.trytalo.talo/Runtime/Entities/LiveConfig.cs

@@ -14,8 +14,15 @@ public LiveConfig(Prop[] props)
 
         public T GetProp<T>(string key, T fallback = default(T))
         {
-            Prop prop = props.First((prop) => prop.key == key);
-            return ((T)Convert.ChangeType(prop.key, typeof(T))) ?? fallback;
+            try
+            {
+                Prop prop = props.First((prop) => prop.key == key);
+                return ((T)Convert.ChangeType(prop.value, typeof(T)));
+            }
+            catch (Exception e)
+            {
+                return fallback;
+            }
         }
     }
 }

Packages/com.trytalo.talo/Tests/Runtime/LiveConfig/GetPropTest.cs

@@ -0,0 +1,59 @@
+using System.Collections;
+using NUnit.Framework;
+using UnityEngine.TestTools;
+using TaloGameServices;
+using UnityEngine;
+using System;
+
+public class GetPropTest
+{
+    [UnityTest]
+    public IEnumerator GetProp_WithALiveConfigThatHasValues_ReturnsCorrectValue()
+    {
+        var config = new LiveConfig(new[] { new Prop(("gameName", "Crawle")), new Prop(("halloweenEventEnabled", "True")) });
+
+        Assert.AreEqual("Crawle", config.GetProp("gameName", "No name"));
+
+        yield return null;
+    }
+
+    [UnityTest]
+    public IEnumerator GetProp_WithAnEmptyList_ReturnsFallback()
+    {
+        var config = new LiveConfig(Array.Empty<Prop>());
+
+        Assert.AreEqual("No name", config.GetProp("gameName", "No name"));
+
+        yield return null;
+    }
+
+    [UnityTest]
+    public IEnumerator GetProp_WithNoMatchingValuesInList_ReturnsFallback()
+    {
+        var config = new LiveConfig(new[] { new Prop(("gameName", "Crawle")), new Prop(("halloweenEventEnabled", "True")) });
+
+        Assert.AreEqual("1.0", config.GetProp("latestGameVersion", "1.0"));
+
+        yield return null;
+    }
+
+    [UnityTest]
+    public IEnumerator GetProp_WhenConvertingTypeToBoolean_ReturnsCorrectValue()
+    {
+        var config = new LiveConfig(new[] { new Prop(("halloweenEventEnabled", "True")) });
+
+        Assert.AreEqual(true, config.GetProp<bool>("halloweenEventEnabled", false));
+
+        yield return null;
+    }
+
+    [UnityTest]
+    public IEnumerator GetProp_WhenConvertingTypeToNumber_ReturnsCorrectValue()
+    {
+        var config = new LiveConfig(new[] { new Prop(("maxLevel", "60")) });
+
+        Assert.AreEqual(60, config.GetProp<int>("maxLevel", 0));
+
+        yield return null;
+    }
+}