Add offline live config cache

[tudddorrr]

No description provided.

[claude]

🔍 Code Review: Add offline live config cache

🚨 Potential Bugs & Issues

GameConfigAPI.cs:17

• SetLiveConfig() call in socket response handler may fail silently if offline caching fails, but won't affect the core functionality. However, consider whether socket updates should trigger cache writes when offline.

LiveConfig.cs:44-47

• GetOfflineConfigLastModified() returns 0 on any exception, which could mask legitimate file system issues. Consider returning a nullable long or a more specific error code to distinguish between "file doesn't exist" vs "permission error" vs "corruption".

---

⚡ Performance Considerations

GameConfigAPI.cs:38-39

• WriteOfflineConfig() is called synchronously on every config load/update, potentially blocking the UI thread for file I/O operations. Consider making this async or using a background thread for file writes.

LiveConfig.cs:32-36

• File writes occur without checking if content has actually changed, leading to unnecessary disk I/O. Consider comparing current cached content before writing.

---

🔒 Security Concerns

LiveConfig.cs:34

• Config data is encrypted via Talo.Crypto.WriteFileContent(), which is good, but there's no validation of the data integrity when reading back from cache. Consider adding checksum validation.

Both files

• No sanitization of file paths (offlineDataPath). While using Application.persistentDataPath is safe, consider validating the constructed path before use.

---

🔄 Backwards Compatibility

GameConfigAPI.cs:13-16

• The change from direct event invocation to SetLiveConfig() method maintains the same event firing behavior, preserving backwards compatibility.

LiveConfig.cs:18

• Updated generic parameter syntax from default(T) to default is C# 7.1+ syntax. Ensure minimum supported Unity version supports this.

---

🏗️ Code Quality & Best Practices

PlayersAPI.cs:14

• Good: Fixed inconsistent field naming from _offlineDataPath to offlineDataPath to match C# conventions.

LiveConfig.cs:10

• Field should be private static readonly instead of just private readonly since it's a constant path used across static methods.

LiveConfig.cs:33-36 & 50-53

• Exception handling swallows all exceptions with generic warnings. Consider more specific exception types and handling (e.g., UnauthorizedAccessException, DirectoryNotFoundException).

GameConfigAPI.cs:26-31

• GetOfflineConfig() method could return null but isn't clearly documented. Consider adding XML documentation or making return type explicitly nullable.

LiveConfig.cs

• Missing XML documentation for public methods, especially GetOfflineConfigLastModified() which has a non-obvious return value meaning.