Add setting for cachePlayerOnIdentify

[tudddorrr]

No description provided.

[claude]

Claude finished @tudddorrr's task —— View job

---

🔍 Code Review: cachePlayerOnIdentify Setting

I've reviewed the changes that add a configurable setting for caching players on identification. Here are potential areas for improvement:

---

🐛 Potential Bugs or Issues

PlayersAPI.cs:138-141 - The WriteOfflineAlias method lacks error handling. If Talo.Crypto.WriteFileContent fails (disk full, permissions, etc.), the exception will propagate without any recovery or graceful degradation.

PlayersAPI.cs:145-146 - The GetOfflineAlias method could throw exceptions if Talo.Crypto.ReadFileContent fails or if the JSON deserialization encounters corrupt data. Consider wrapping in try-catch to prevent crashes during offline mode.

---

🔒 Security Concerns

PlayersAPI.cs:139-140 - Player data is being written to persistent storage without any mention of encryption validation. While Talo.Crypto.WriteFileContent is used, there's no verification that the crypto implementation is actually encrypting the data or handling key management securely.

---

⚡ Performance Considerations

PlayersAPI.cs:145 - File existence check and crypto read operations happen on every GetOfflineAlias call. Consider caching the result in memory after first successful read to avoid repeated disk I/O, especially if this method is called frequently.

PlayersAPI.cs:138-140 - Writing to disk synchronously on every successful identification could cause frame drops in the main thread. Consider making this operation asynchronous or queuing it for background execution.

---

🔄 Backwards Compatibility

TaloSettings.cs:36 - The new cachePlayerOnIdentify setting defaults to true, which changes the default behavior for existing projects. This could create unexpected offline data files in games that previously didn't cache anything. Consider defaulting to false to maintain existing behavior.

---

📋 Review Tasks

• Read repository guidelines (CLAUDE.md)
• Analyze modified files for code quality issues
• Check for potential bugs and security concerns
• Evaluate performance and backwards compatibility
• Provide comprehensive review feedback

---