Bumping to allow Serilog 4.* #122
Conversation
|
@rnishtala-sumo Could you review this PR? |
|
@JoshGlue @rnishtala-sumo @francisphn is this one waiting on anything in order to be merged? Is there anything that can be done to help? |
|
It's been a few weeks without any activity. We would also like to have this merged. |
|
The previous PR took three months to upgrade Serilog from version 2.x to 3.x (#119). This current PR is also taking a significant amount of time to be merged. Could we consider setting the versioning like this? <ItemGroup Condition=" '$(TargetFramework)' == 'netstandard2.0' ">
<PackageReference Include="Serilog" Version="[2.0,)" />
</ItemGroup>This approach would allow us to update the Serilog package without being restricted by the |
Don't set max major version for Serilog dependency
|
@JoshGlue good call, updated that. [Insert Jeopardy Theme Music Here] |
| </ItemGroup> | ||
| <ItemGroup Condition=" '$(TargetFramework)' == 'netstandard2.0' "> | ||
| <PackageReference Include="Serilog" Version="[2.0,4.0)" /> | ||
| <PackageReference Include="Serilog" Version="[2.0,)" /> |
There was a problem hiding this comment.
I don't have enough context here, if this is bumping up to allow Serilog 4.*, why is the change removing 4.0?
There was a problem hiding this comment.
The PR removes the requirement for at specific version of Serilog, except above version 2.0.
Basically the parentesens and braces indicate "including or not", so before they meant above 2.0, but below 4.0. This means you could install 2.2.x, 3.x.x, but no 4.x.x.
Removing the 4.0 from the PackageReference just means 2.0 and above.
There was a problem hiding this comment.
Ah gotcha, didn't noticed the bracket and parenthesis. Makes alot more sense, approved!
|
Who can merge this PR? |
|
When can we expect a new package to be available? |
8 participants
Serilog 4.* released without any major breaking changes, this is needed to allow for Serilog sinks to take advantage of the new batching sinks that are native and not in a separate package anymore.