Add image with cruise-control-metrics-reporter jar already downloaded #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and recommends Scala 2.12 so let's upgrade everything. While we're at it add download verification.
until Java 11 build is supported. This reverts commit a1cf20e.
Use Java 11 everywhere
in Yolean/kubernetes-kafka#218 Because downloading from an external server at broker pod start is a risk.
|
Merged manually |
solsson
added a commit
to Yolean/kubernetes-kafka
that referenced
this pull request
Dec 20, 2018
because it might prevent broker restart if the remote server is down Using image from StreamingMicroservicesPlatform/docker-kafka#8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should reduce the risk of failed Kafka inits in Yolean/kubernetes-kafka#218