-
Notifications
You must be signed in to change notification settings - Fork 2
v0.0.3 #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@Erkaman @rreusser @dustindorroh @cczarnocki The python notebook now runs on Colab! Since the repo isn't open source, you have to do a few things to get it working:
Now you can go to Runtime > Run All to run all cells, or run them one by one, or whatever you want. |
|
"The user provides as parameters a 'max_slop' (a time duration) and a 'max_queue_size' (a number of messages to buffer" buffer? what does this buffer do? its the first time its even mentioned. |
|
"If topics have messages recorded at somewhat different times (e.g. two sensors both record at 5Hz, but one records 50ms before the other), then MaxSlopTimeSync will find the nearest matches." ok. im interested in how it actually does this. how finds the nearest matches. please write down a short summary of the algorithm used. otherwise, the thing feels like a black-box to me, which i dont like, |
|
I can definitely see the utility of using |
|
what does the |
|
@scpwais left all my feedback above. |
|
thanks @Erkaman ! Linked in what you read is the MaxSlopTimeSync docs; here's that link again: MaxSlopTimeSync I think that will answer most of your questions. You might also consult the unit tests for MaxSlopTimeSync and for IterProducts. I'll update the notebook a bit to make these more conspicuous. |
|
"what does the nanos=0 argument do?" -- nanos is nanoseconds |
In this revision:
protobagexamplessubdir@rreusser @Erkaman @dustindorroh @cczarnocki would love your feedback on the python notebook demo. For now it's easiest to just read the version stored on Github (versus try to run it). Here's a permalink to the latest revision at time of writing: https://github.com/StandardCyborg/protobag/blob/aed9ea01d91eaecc838972a0a85bfc4d79b0d6d3/examples/protobag-to-parquet/protobag-demo-full.ipynb