Skip to content

Conversation

Avital-Fine
Copy link
Contributor

@Avital-Fine Avital-Fine requested a review from mgravell April 4, 2022 10:47
Copy link
Collaborator

@NickCraver NickCraver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good - thanks! There are a few things I'd like to remedy inline and test a bit better but overall great. I'm happy to make the suggested changes and push if preferred soon as time allows, let me know :)

Avital-Fine and others added 3 commits April 4, 2022 18:34
Also adds a new version-based skip override so we can more simply apply this in ongoing PRs.
@NickCraver NickCraver self-requested a review April 8, 2022 01:29
Copy link
Collaborator

@NickCraver NickCraver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current is looking great - thanks for this!

@NickCraver NickCraver merged commit 58cbef0 into StackExchange:main Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants