Skip to content

Conversation

@NickCraver
Copy link
Collaborator

@NickCraver NickCraver commented Mar 21, 2020

Overall changes:

  • Adds counters for connection attempts, completions, and closures
  • Uses those counters for more informative error messages for the "no connection is available"
    • 3 variants now:
      • "Connection to Redis never succeeded (1 attempt - connection likely in-progress), unable to service operation: "
      • "Connection to Redis never succeeded ({attempts} attempts - check your config), unable to service operation: "
      • "No connection is active/available to service this operation: "
  • Adds our counter info (currently only on timeouts) to the above exceptions
  • Simplifies the ExceptionFactory.NoConnectionAvailable signature
  • Moves SubscriptionsSurviveMasterSwitchAsync to DEBUG (unrelated, it was being a PITA though)

Open questions:

  • This tracks overall counts - is that the right approach? Or should we move this to ServerCounters? The intent is overall, but re-connections have semantic differences between per endpoint and global. For example, we could be successfully connected to only a slave, and have no successful to a master which means we still have no viable connection to satisfy the request.
  • If global is the path, are these in the right place?

Let's hang and go over this one - I'm not attached to anything here, just trying to improve the reporting for our next release.

Nick Craver added 7 commits March 21, 2020 09:31
Note: I know mutiplexer isn't spelled right - will fix that in a follow-up to avoid noise.
Broken since the 2.1 bump, oops
Simpifies usage for all callers. Also shares code and adds diagnostics to the "no connection" case.
SubscriptionsSurviveMasterSwitchAsync is a thorn in our side - moving to DEBUG.
@NickCraver NickCraver changed the title WIP: Better Connection Counts & Error Messages Better Connection Counts & Error Messages Mar 23, 2020
@NickCraver NickCraver marked this pull request as ready for review March 23, 2020 01:45
@NickCraver NickCraver requested a review from mgravell March 23, 2020 01:45
Nick Craver added 4 commits March 22, 2020 22:07
@mgravell mgravell merged commit a01cd04 into master Mar 23, 2020
@NickCraver NickCraver deleted the craver/connection-counts branch March 23, 2020 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants