Implement ChunkExecutor
#4216
Open
Implement ChunkExecutor
#4216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alejoe91
added
core
alejoe91
commented
Nov 14, 2025
h-mayorquin
reviewed
Nov 17, 2025
| self._recording_segments.append(recording_segment) | ||
| recording_segment.set_parent_extractor(self) | ||
|
|
||
| def get_sample_size(self): |
Collaborator
There was a problem hiding this comment.
Suggested change
| def get_sample_size(self): | |
| def get_sample_size_in_bytes(self): |
I think that some people might mistake the method name for shape or number of samples if we don't specify it this way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes a
ChunkExecutorwhich is agnostic to the recording and applies to any chunkableBaseExtractor(which definesget_sample_size(), get_num_samples(), get_num_segments()This is because we are working on a new "spikeinterface" for calcium imaging, and this refactor makes it suuuuper straightforward to use the same parallelization machinery for
Imagingobjects (which inherit from theBaseExtractor)