A new sorter : Lupin sorter #4192
Open
+564
−126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…erface into memory_template_similarity
for more information, see https://pre-commit.ci
…erface into memory_template_similarity
for more information, see https://pre-commit.ci
…e into lupin_sorter
…ikeinterface into lupin_sorter
Member
Author
|
@alejoe91 @chrishalcrow |
for more information, see https://pre-commit.ci
| mode="memory", | ||
| memory_limit=0.5, | ||
| total_memory=None, | ||
| delete_cache=True, |
Member
There was a problem hiding this comment.
You don't use delete_cache anywhere
| # sparsity_snr = compute_sparsity(templates_dense, method="snr", amplitude_mode="peak_to_peak", | ||
| # noise_levels=noise_levels, threshold=sparsity_threshold) | ||
| # sparsity.mask = sparsity.mask & sparsity_snr.mask | ||
| # templates = templates_dense.to_sparse(sparsity) |
Member
There was a problem hiding this comment.
Go through and delete not-needed comments, please
| # sparsity_mask=None, | ||
| # probe=recording_for_peeler.get_probe(), | ||
| # is_in_uV=False, | ||
| # ) |
Member
There was a problem hiding this comment.
loads of commented out stuff in this file
| # detection | ||
| ms_before = params["ms_before"] | ||
| ms_after = params["ms_after"] | ||
| prototype, few_waveforms, few_peaks = get_prototype_and_waveforms_from_recording( |
Member
There was a problem hiding this comment.
There's quite a lot of unused variables in Lupin. Stuff like few_waveforms, few_peaks here, more_outs on line 242, unit_locations on 266. Guessing it's fine - just checking that you're not accidentally not using them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gentleman thief spike sorter.
This sorter is composed by pieces of code and ideas stolen everywhere : yass, tridesclous, spkyking-circus, kilosort.
It should be the best sorter we can build using spikeinterface.sortingcomponents
This depend on #4182