Skip to content

Conversation

@alejoe91
Copy link
Member

No description provided.

@alejoe91 alejoe91 added testing Related to test routines continuous integration Related to CI labels Feb 11, 2025
@alejoe91
Copy link
Member Author

All good but Windows 3.13 @chrishalcrow

@JoeZiminski
Copy link
Collaborator

JoeZiminski commented Feb 12, 2025

Looks very similar (identical?) to this: numpy/numpy#27894

but the numpy version in use here is numpy-1.26.4

Oh maybe 1.26.4 does not work on python 3.13 https://numpy.org/devdocs/release/1.26.4-notes.html

I'm not sure why it is resolving to numpy 1.26.4, it might be worth forcing to numpy>=2 if python 3.13, this should be possible in the pyproject.toml with dependency specifiers. This stuff always gives me a headache, maybe something like (untested):

    "numpy>=1.20" ; python_version<'3.13'",
    "numpy>=2.0.0" ; python_version>='3.13'",

(assuming the numpy version is the issue)

@chrishalcrow
Copy link
Member

What fun! New error is that elephant 1.1.0 imports a depreciated scipy function; if we could get to elephant 1.1.1, that'd be fixed.

@alejoe91
Copy link
Member Author

This is mainly due to MEArec, which uses elephant. Just made a release to have local elephant imports, since it's only used at generation. Let's retrigger and see how it goes :)

@alejoe91
Copy link
Member Author

depends on #3689

Copy link
Member

@chrishalcrow chrishalcrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done @alejoe91 , looks good to me!

@alejoe91 alejoe91 merged commit dd0c6d3 into SpikeInterface:main Feb 13, 2025
15 checks passed
dhmjhu added a commit to regro-cf-autotick-bot/spikeinterface-feedstock that referenced this pull request Feb 19, 2025
dhmjhu added a commit to regro-cf-autotick-bot/spikeinterface-feedstock that referenced this pull request Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

continuous integration Related to CI testing Related to test routines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants