Numpy 2.0 cap Fix most egregorious deprecated behavior and cap version #3032
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
h-mayorquin
added
dependencies
Closed
zm711
reviewed
Jun 17, 2024
Member
zm711
left a comment
zm711
left a comment
There was a problem hiding this comment.
Just a couple typos to fix on my part.
Co-authored-by: Zach McKenzie <[email protected]>
Co-authored-by: Zach McKenzie <[email protected]>
Collaborator
Author
|
Thanks @zm711 |
Member
|
Merci beaucoup. |
samuelgarcia
approved these changes
Jun 18, 2024
alejoe91
reviewed
Jun 18, 2024
alejoe91
reviewed
Jun 18, 2024
alejoe91
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to fix the failing tests so we can move on.
Plus, this should make the core compatible with numpy 2.0.
We can't offer support yet because some packages (like scipy and numba) would require us to put lower versions on them.
We can discuss how to move forward with this in an issue that I will link soon.