Skip to content

Conversation

@iooner
Copy link

@iooner iooner commented Oct 19, 2025

Update Twitter username description to 'X username' in desc and add instagram feed

Update Twitter username description to 'X username' in desc
and add instagram feed
Comment on lines +374 to 380
"instagram": {
"description": "URL to Instagram profile",
"type": "string",
"examples": [
"https://www.instagram.com/examplespace"
]
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I'm not a fan of Instagram at all (since the Meta takeover), I can see that some spaces might have an account. As such, it probably makes sense to add it to the schema.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At the moment, a total of 7 spaces in the directory list an Instagram account as contact.instagram or contact.ext_instagram. A slight majority seems to go by URL rather than account name only:

"ext_instagram": "leighhackspace"
"instagram": "https://www.instagram.com/netz_39/"
"instagram": "https://www.instagram.com/farsetlabs"
"instagram": "https://www.instagram.com/hackspace_siegen/"
"instagram": "segvaultspace"
"instagram": "https://www.instagram.com/hack.manhattan/"
"instagram": "@MakeSpaceMadrid"

I'm in favor of going with the URL over username only.

Comment on lines 261 to 267
"twitter": {
"description": "Twitter username with leading <code>@</code>",
"description": "X username with leading <code>@</code>",
"type": "string",
"examples": [
"@space_api"
]
},
Copy link
Contributor

@dbrgn dbrgn Oct 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably deprecate the twitter key below keymasters, it doesn't really make sense there.

What do you think, @SpaceApi/core?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That will break backward compatibility with previous versions of the API.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That will break backward compatibility with previous versions of the API.

Our policy is to deprecate things in version x and then remove them in x+1. The reason we have a versioned API is that we have breaking changes from time to time.

Comment on lines 303 to 309
"twitter": {
"description": "Twitter username with leading <code>@</code>",
"description": "X username with leading <code>@</code>",
"type": "string",
"examples": [
"@space_api"
]
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also deprecate the twitter key as well and add a new x or x.com key.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we change this, I'd definitely prefer x.com over x, both in the key and in the description (or something like X (formerly Twitter)). A single letter is far too overloaded, and not everyone will think of that platform when reading "x". E.g. personally, if someone tells me "they're using X", my first thought is the Linux window system 🙃

Copy link
Member

@s3lph s3lph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any changes done in this PR also need to be reflected in the changelog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants