Skip to content

Ensure that each billing address form DOM element has a unique id #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 12, 2018
Merged

Ensure that each billing address form DOM element has a unique id #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,14 @@
]
}
},
"magento/module-checkout": {
"Ensure that each billing address form DOM element has a unique id https://github.com/magento/magento2/pull/15349": {
"source" : "patches/Magento_Checkout/billing-address-form.patch",
"version" : [
"100.2.*"
]
}
},
"magento/module-configurable-product": {
"Add frontend validation for SKU on configurable product variation generation in admin panel": {
"source" : "patches/Magento_ConfigurableProduct/magento2-issue-11953.patch",
Expand Down
13 changes: 13 additions & 0 deletions patches/Magento_Checkout/billing-address-form.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
diff --git a/view/frontend/web/template/billing-address/form.html b/view/frontend/web/template/billing-address/form.html
index 1be754934042..00f87d325d96 100644
--- a/view/frontend/web/template/billing-address/form.html
+++ b/view/frontend/web/template/billing-address/form.html
@@ -9,7 +9,7 @@
<!-- ko template: getTemplate() --><!-- /ko -->
<!--/ko-->
<form data-bind="attr: {'data-hasrequired': $t('* Required Fields')}">
- <fieldset id="billing-new-address-form" class="fieldset address">
+ <fieldset data-bind="attr: { id:'billing-new-address-form-'+index, value:index}" class="fieldset address">
<!-- ko foreach: getRegion('additional-fieldsets') -->
<!-- ko template: getTemplate() --><!-- /ko -->
<!--/ko-->