Feature/GitHub issues #64

Ericode254 · 2025-08-12T22:56:04Z

fetch issues from all repos
use keymaps from bubbletea

…f a particular repo - Will enable a user to configure github issues section using a personal access token from github for authentication - Users will be able to see issues on a particular repo of their choosing and be also be able to create notes on them - You can filter and sort the notes - Their is an overlay for help

- Remove some comments where the code is self explanatory - Update the readme with the github setup instructions

- Reverted the colors to how the were - Removed the convert to note functionality - Add an overlay for each note for full information

NucleoFusion · 2025-08-13T05:26:23Z

internal/models/viewer/viewer.go

viewer.go should not have any changes since it is unrelated to your PR

can you paste the diff please bacause i dont remember changing this file

Idk how I can, you can check the diff in the PR (files changed) section
I cant seem to attach it

NucleoFusion · 2025-08-13T05:26:51Z

internal/models/diary/diary.go

diary.go should have no changes, its unrelated to your PR

if you look at the file you will see i did not change the file i had accidentaly deleted a line then i pasted it at the top

No, the style is changes, form FocusedBorder -> Border

NucleoFusion · 2025-08-13T05:28:34Z

internal/models/rootModel.go

+	case enums.GitHubPage:
+		if m.GitHub != nil {
+			return m.GitHub.View()
+		}
+		return "GitHub model not initialized"


Do not keep it nil, it leaves room for error
Make sure its always initialized, even though it may hold no values in it, it should be initialized.

NucleoFusion · 2025-08-13T05:30:47Z

internal/models/rootModel.go

To make sure its always initialized, add Github model initialization to the
tea.WindowSizeMsg case in Update()

so want it not to be optional anymore but a requirement for users to setup the github issues

No, if it is not setup then no worries, just show "Github Not Setup" or something in the page. Just dont hide it if not setup. People should know it exists

NucleoFusion · 2025-08-13T05:31:35Z

internal/models/menu/menulist.go

Similarly, if the nil case is handled in root.go properly
Github entry can be in Selection always.

that would make it not optional anymore though or is that the point

i understand now

NucleoFusion · 2025-08-13T05:32:31Z

internal/models/github/setup.go

This is a big file, Ill check it once other stuff is completed

NucleoFusion · 2025-08-13T05:32:58Z

internal/models/github/github.go

This is a big file Ill check once other stuff is compelted

NucleoFusion · 2025-08-13T05:33:45Z

internal/models/github/api.go

+func (api *GitHubAPI) FetchIssues() ([]GitHubIssue, error) {
+	if api.token == "" {
+		return nil, fmt.Errorf("GitHub token is missing")
+	}
+	return api.FetchAllIssuesForUser()
+}


redundant function

sorry i thought it would be easier but was in a harry didnt see the redundancy

NucleoFusion · 2025-08-13T05:34:11Z

internal/models/github/api.go

This is a big file, Ill check it once other stuff is completed

NucleoFusion · 2025-08-13T05:34:38Z

cmd/github.go

This is a big file, Ill check it once other stuff is completed

NucleoFusion · 2025-08-13T05:35:18Z

Remember to keep resolving each review comment, so you and I both can keep a better track at whats done or is left

NucleoFusion · 2025-08-14T07:23:29Z

Okay, so I was thinking, and rather than github issues being a seperate thing, I want it to be kind of like a tab inside the Daily Tasks section. So maybe you get the logic sorted whilst I also work at revamping the Daily Tasks section so it can fit the use case

NucleoFusion · 2025-08-16T06:28:43Z

Are you still gonna work on it?
I am making some changes to the tasks section, so You will have to accomadate them

Ericode254 · 2025-08-16T20:33:09Z

yeah am gonna work on it, just been a little busy

NucleoFusion · 2025-08-17T05:55:58Z

I added changes to the Daily Tasks Section. Now we have tabs inside the Daily Tasks Page, so instead of a seperate Github Page, add it there.
In All -> Show all Tasks (incl Github Ones, custom style)
In Github -> Show Github Tasks (Filter in the daily.go section, In Refresh())

Ericode254 · 2025-08-17T20:13:00Z

okay

NucleoFusion · 2025-08-18T07:13:23Z

internal/enums/task.go

-	All       TaskTabs = "All"
+	Tasks     TaskTabs = "Tasks"


Dont change what is not needed
This is a good change, but for this it should be a separate PR.

sorry about that will change it back

NucleoFusion · 2025-08-18T07:13:47Z

internal/keymap/dailytasks.go

+			key.WithHelp("right", "tasks/github tab"),
 		),
 		TabLeft: key.NewBinding(
 			key.WithKeys("left"),
-			key.WithHelp("left", "left tab"),
+			key.WithHelp("left", "tasks/github tab"),


Keep left/right tab
This is a circularly linked, so that doesnt make sense

NucleoFusion · 2025-08-18T07:14:38Z

internal/models/daily/daily.go

+type GitHubSyncMsg struct {
+	Issues []github.GitHubIssue
+	Error  error
+}
+


messages in messages package

NucleoFusion · 2025-08-18T07:14:53Z

internal/models/daily/daily.go

-		Tabs:       []enums.TaskTabs{enums.All, enums.Unique, enums.Recurring, enums.Github},
+		Tabs:       []enums.TaskTabs{enums.Tasks, enums.Github},


sorry forgot to remove them

NucleoFusion · 2025-08-18T07:17:42Z

internal/models/daily/daily.go

+			// Check if selected item is a GitHub task
+			item := m.List.SelectedItem()
+			if _, isGithubTask := item.(GithubTask); isGithubTask {
+				return m, nil // Don't allow deletion of GitHub tasks
+			}


Why? Allow for all, If user deletes, its up to him

NucleoFusion · 2025-08-18T07:22:08Z

internal/models/daily/daily.go

+func convertGitHubIssuestoGithubTasks(issues []github.GitHubIssue) []GithubTask {
+	tasks := make([]GithubTask, len(issues))
+	for i, issue := range issues {
+		// Extract owner and repo from the repo field (format: "owner/repo")
+		repoParts := strings.Split(issue.Repo, "/")
+		owner := ""
+		repo := ""
+		if len(repoParts) == 2 {
+			owner = repoParts[0]
+			repo = repoParts[1]
+		}
+
+		tasks[i] = GithubTask{
+			TaskTitle: issue.IssueTitle,
+			TaskDesc:  issue.Body,
+			Status:    enums.Pending, // GitHub issues are typically "pending" in task context
+			Ref:       fmt.Sprintf("#%d", issue.Number),
+			Repo:      repo,
+			Owner:     owner,
+			Link:      issue.HTMLURL,
+			Labels:    convertLabelsToStrings(issue.Labels),
+			Assignee:  issue.Assignees,
+		}
+	}
+	return tasks
+}


This Shouldnt be here, attach it to the GithubTask type in the items.go file

NucleoFusion · 2025-08-18T07:22:58Z

internal/models/daily/items.go

-	lst1 := TaskToItems(m.Recurring)
-	lst2 := TaskToItems(m.Unique)
+	lst1 := RecurringTaskToItems(m.Recurring)
+	lst2 := UniqueTaskToItems(m.Unique)



Why? Different functions?
Excess code not needed. Both are of same type, one function can be used

NucleoFusion · 2025-08-18T07:23:51Z

internal/models/daily/items.go

+func UniqueTaskToItems(tasks []Task) []list.Item {
+	list := make([]list.Item, 0)
+	for i, v := range tasks {
+		v.Index = i
+		v.TaskType = enums.UniqueTask
+		list = append(list, v)
+	}
+	return list
+}


Unnecessary

NucleoFusion · 2025-08-18T07:24:13Z

internal/models/daily/taskDelegate.go

+		}
+	} else if gt, ok := item.(GithubTask); ok {
+		// Handle GitHub Task with special styling
+		githubIcon := "🐙" // GitHub icon


Thats not a github icon

will just add text

NucleoFusion · 2025-08-18T07:24:40Z

internal/models/daily/taskDelegate.go

+		repoInfo := fmt.Sprintf("[%s/%s%s]", gt.Owner, gt.Repo, gt.Ref)
+
+		switch gt.Status {
+		case enums.Complete:
+			text += fmt.Sprintf("%s\n%s",
+				styles.CompletedStyle().Title.Render(fmt.Sprintf("%s | %s %s", cfg.CompletedIcon, Shorten(gt.Title(), 25), repoInfo)),
+				styles.CompletedStyle().Desc.Render(fmt.Sprintf("%s %s", githubIcon, Shorten(gt.Description(), 50))),
+			)
+		case enums.Pending:
+			text += fmt.Sprintf("%s\n%s",
+				styles.PendingStyle().Title.Render(fmt.Sprintf("%s | %s %s", cfg.PendingIcon, Shorten(gt.Title(), 25), repoInfo)),
+				styles.PendingStyle().Desc.Render(fmt.Sprintf("%s %s", githubIcon, Shorten(gt.Description(), 50))),
+			)
+		case enums.Started:
+			text += fmt.Sprintf("%s\n%s",
+				styles.StartedStyle().Title.Render(fmt.Sprintf("%s | %s %s", cfg.StartedIcon, Shorten(gt.Title(), 25), repoInfo)),
+				styles.StartedStyle().Desc.Render(fmt.Sprintf("%s %s", githubIcon, Shorten(gt.Description(), 50))),
+			)
+		case enums.Abandoned:
+			text += fmt.Sprintf("%s\n%s",
+				styles.AbandonedStyle().Title.Render(fmt.Sprintf("%s | %s %s", cfg.AbandonedIcon, Shorten(gt.Title(), 25), repoInfo)),
+				styles.AbandonedStyle().Desc.Render(fmt.Sprintf("%s %s", githubIcon, Shorten(gt.Description(), 50))),
+			)
+		default:
+			// Default to pending style for GitHub issues (since they're typically open)
+			text += fmt.Sprintf("%s\n%s",
+				styles.PendingStyle().Title.Render(fmt.Sprintf("%s | %s %s", cfg.PendingIcon, Shorten(gt.Title(), 25), repoInfo)),
+				styles.PendingStyle().Desc.Render(fmt.Sprintf("%s %s", githubIcon, Shorten(gt.Description(), 50))),
+			)
+		}
+	} else {
+		return
 	}


Lets Discuss How we want it to look, the Github Task formats

what do you suggest

NucleoFusion · 2025-08-18T07:28:47Z

Okay so after you do changes, please run it and see if it works before putting a PR.
Also, again I am saying, do not do changes unrelated to your PR.
The Fetch Issues thing still remains, Assigned & Open Issues, not closed ones.

This is a big PR, this also paves the way for future Github Integration for everything to be done right, If you want to move to a simpler PR first, go for it, I will co-author the rest of the PR (your name will still be attached to the PR). If you do want to continue with this, then just comment here.

But please take my advice of checking your work before PR-ing, the Home is also still broken in this for me.

Ericode254 · 2025-08-19T20:07:46Z

can you explain how the home is broken for you because i dont remember touching it

Ericode254 · 2025-08-19T20:59:44Z

dont worry i have seen how the home page was broken, i think

- Fixed the broken viewport of the home page - removed unnecessary code

NucleoFusion

Bro you have changed everything, some previous changes are still not resolved and you have merged unique and recurring for some reason everywhere.
This is not how it works

At this point i cant even consider merging this branch, since it has too many changes and too many commits.
If you do want to continue with this, I would say delete this branch and start fresh with the PR.
If you want to look at how I have implemented TODO task integration, similar to the Github one, Ill put up a PR for it, its probably 200-300 lines of code, compared to your 1.6k lines. It will tell you how it should be done nicely.

Try to vibe less, the more AI you use the more it will mess up the repo. This is an OSS project, not a sideproject. It needs a certain level of quality for its code.

NucleoFusion · 2025-08-24T04:58:05Z

internal/config/default.go

+				Create:       "c",
+				Edit:         "e",
+				StatusChange: "s",
+				Delete:       "d",
+				ExitPopup:    "esc",
+				Enter:        "enter",
+				FormUp:       "ctrl+up",
+				FormDown:     "ctrl+down",
+				BackToMenu:   "esc",


removed createRecurring?

NucleoFusion · 2025-08-24T04:58:31Z

internal/config/keybinds.go

+	Create       string `mapstructure:"create"`
+	Delete       string `mapstructure:"delete"`
+	StatusChange string `mapstructure:"status_change"`
+	Edit         string `mapstructure:"edit"`
+	BackToMenu   string `mapstructure:"return_to_menu"`
+	FormUp       string `mapstructure:"form_up"`
+	FormDown     string `mapstructure:"form_down"`
+	ExitPopup    string `mapstructure:"exit_popup"`
+	Enter        string `mapstructure:"enter"`


Same here
why are you changing the keybinds? that are irrelevant to your PR

NucleoFusion · 2025-08-24T04:59:06Z

internal/enums/task.go

-	Tasks     TaskTabs = "Tasks"
-	Unique    TaskTabs = "Unique"
-	Recurring TaskTabs = "Recurring"
-	Github    TaskTabs = "Github"
+	Tasks  TaskTabs = "Tasks"
+	Github TaskTabs = "Github"
 )


Same here
we want Unique and Recurring to be seperate
thats the whole point of the feature

NucleoFusion · 2025-08-24T04:59:26Z

internal/enums/taskPopup.go

 const (
-	CreateUnique = iota
-	CreateRecurring
+	CreateTask = iota


same here, unique and recurring are combined

NucleoFusion · 2025-08-24T04:59:45Z

internal/enums/tasktype.go

-
-const (
-	RecurringTask = iota
-	UniqueTask
-)


need i say something?

NucleoFusion · 2025-08-24T04:59:57Z

internal/keymap/dailytasks.go

+	CreateTask    key.Binding
+	EditTask      key.Binding
+	ChangeStatus  key.Binding
+	DeleteTask    key.Binding
+	BackToMenu    key.Binding
+	TabRight      key.Binding
+	TabLeft       key.Binding
+	RefreshGithub key.Binding
 }


NucleoFusion · 2025-08-24T05:01:01Z

internal/models/daily/daily.go

@@ -77,16 +76,14 @@ func (m *Daily) Update(msg tea.Msg) (tea.Model, tea.Cmd) {
 			m.Tasks.Github = []GithubTask{}
 		} else {
 			m.GithubError = ""
-			m.Tasks.Github = convertGitHubIssuestoGithubTasks(msg.Issues)
+			m.Tasks.Github = ConvertGitHubIssuestoGithubTasks(msg.Issues)


i remember saying to attach this function to the Github Tasks type right?

my bad, the issues type

NucleoFusion · 2025-08-24T05:01:26Z

internal/models/daily/daily.go

-		case enums.CreateRecurring:
-			fallthrough
-		case enums.CreateUnique:
-			m.CreateTask(msg, msg.Type == enums.CreateUnique)
+		case enums.CreateTask:
+			m.CreateTask(msg)


NucleoFusion · 2025-08-24T05:01:35Z

internal/models/daily/daily.go

-		case key.Matches(msg, m.Keymap.CreateUnique):
-			m.Popup = taskpopup.NewPopup(m.Width, m.Height, enums.CreateUnique)
-			m.ShowPopup = true
-			return m, nil
-		case key.Matches(msg, m.Keymap.CreateRecurring):
-			m.Popup = taskpopup.NewPopup(m.Width, m.Height, enums.CreateRecurring)
+		case key.Matches(msg, m.Keymap.CreateTask):
+			m.Popup = taskpopup.NewPopup(m.Width, m.Height, enums.CreateTask)


NucleoFusion · 2025-08-24T05:02:51Z

internal/models/daily/handlers.go

-func (m Daily) CreateTask(msg messages.TaskPopupMessage, isUnique bool) {
+func (m Daily) CreateTask(msg messages.TaskPopupMessage) {
 	task := Task{
 		TaskTitle: msg.Title,
 		TaskDesc:  msg.Desc,
 		Status:    msg.Status,
 	}

-	if isUnique {
-		m.Tasks.Unique = append(m.Tasks.Unique, task) // Seperate Task Input for recurring / unique tasks
-	} else {
-		m.Tasks.Recurring = append(m.Tasks.Recurring, task) // Seperate Task Input for recurring / unique tasks
-	}
+	m.Tasks.All = append(m.Tasks.All, task)
 	WriteItems(m.Tasks)
 }


Ericode254 added 10 commits August 11, 2025 02:54

my modules update

9e70e8f

refactor: remove unnecessary comments

10a3547

- Remove some comments where the code is self explanatory - Update the readme with the github setup instructions

refactor: formatted the code using go format

ab0130e

refactor: make some changes

3b4696e

- Reverted the colors to how the were - Removed the convert to note functionality - Add an overlay for each note for full information

refactor: formatted the github.go file

a3ff1f7

refactor: removed the widgets and themes files

3bfd8dc

refactor: removed unnecessary variables

e35897a

refactor: fetch all open issues from all the repos for that user

7220983

refactor: fetch also assigned issues

6c613d5

Ericode254 requested a review from NucleoFusion as a code owner August 12, 2025 22:56

Ericode254 added 2 commits August 13, 2025 01:59

Merge branch 'dev' into feature/githubIssues

c47ecd1

refactor: formatted the code

a77ea6b

NucleoFusion requested changes Aug 13, 2025

View reviewed changes

Ericode254 added 3 commits August 17, 2025 23:25

Merge branch 'origin/dev' into feature-branch

0e4ea61

refactor: combined the tasks with github issues

03c16fc

refactor: remove duplicate code

2ed6b20

NucleoFusion requested changes Aug 18, 2025

View reviewed changes

refactor: removed the functionality for recurring tasks

63882b3

- Fixed the broken viewport of the home page - removed unnecessary code

NucleoFusion reviewed Aug 24, 2025

View reviewed changes

		Tabs: []enums.TaskTabs{enums.All, enums.Unique, enums.Recurring, enums.Github},
		Tabs: []enums.TaskTabs{enums.Tasks, enums.Github},

Feature/GitHub issues #64

Are you sure you want to change the base?

Feature/GitHub issues #64

Uh oh!

Conversation

Ericode254 commented Aug 12, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

NucleoFusion commented Aug 13, 2025

Uh oh!

NucleoFusion commented Aug 14, 2025

Uh oh!

NucleoFusion commented Aug 16, 2025

Uh oh!

Ericode254 commented Aug 16, 2025

Uh oh!

NucleoFusion commented Aug 17, 2025

Uh oh!

Ericode254 commented Aug 17, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment