Skip to content

Some scripts are tagged as tests when they should not #311

@dgarijo

Description

@dgarijo

Right now we check if the assert commands are used in tests.
I have detected some places (e.g., repo Tface) where the assert expressions are used just to check if the inputs to the script are correct. This is not a good practice, but we should not assume that any function with assert is a test. Alternatives:

  • Check if any of the imports include the test frameworks.
  • Check if the assert functions are the last call in the target function. This way, we'll know it is a test instead of asserting a in input condition.

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions