Skip to content

fix: Type issue for non-default DeviceCommandHandlers #256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix: Type issue for non-default DeviceCommandHandlers #256

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions lib/smart-app.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { IncomingHttpHeaders } from 'http'
import { i18n } from './i18n'
import ConfigurationOptions = i18n.ConfigurationOptions
import { Logger } from './util/log'
import { DeviceCommand, InstalledAppConfiguration } from '@smartthings/core-sdk'
import { InstalledAppConfiguration } from '@smartthings/core-sdk'
import { Page } from './pages/page'
import { SmartAppContext } from './util/smart-app-context'
import { AppEvent } from './lifecycle-events'
Expand All @@ -15,6 +15,7 @@ import ModeEvent = AppEvent.ModeEvent
import SceneLifecycleEvent = AppEvent.SceneLifecycleEvent
import TimerEvent = AppEvent.TimerEvent
import DeviceCommandsEvent = AppEvent.DeviceCommandsEvent
import DeviceCommandsEventCommand = AppEvent.DeviceCommandsEventCommand
import SecurityArmStateEvent = AppEvent.SecurityArmStateEvent
import ExecuteData = AppEvent.ExecuteData
import UninstallData = AppEvent.UninstallData
Expand Down Expand Up @@ -288,7 +289,7 @@ export class SmartApp {
callback: (
context: SmartAppContext,
deviceId: string,
cmd: DeviceCommand) => HandlerResponse): SmartApp
cmd: DeviceCommandsEventCommand) => HandlerResponse): SmartApp

/**
* Defines a handler that is called for any configuration page that does not have a specific page handler
Expand All @@ -310,7 +311,7 @@ export class SmartApp {
deviceCommand(command: string, callback: (
context: SmartAppContext,
deviceId: string,
cmd: DeviceCommand,
cmd: DeviceCommandsEventCommand,
eventTime?: string) => HandlerResponse): SmartApp

/**
Expand Down