ENH: Add more automatic tests #2194
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lassoan
force-pushed
the
add-more-automatic-tests
branch
2 times, most recently
from
5aba0b7 to
d5ba1d4
Compare
|
I just removed the requirements to have the Circle tests & I also just updated the associated CircleCI project to "disable" the webhook. |
jcfr
force-pushed
the
add-more-automatic-tests
branch
from
d5ba1d4 to
9f8dce8
Compare
jcfr
reviewed
Aug 9, 2025
Move filename checks from bash script executed by CircleCI to Python script executed by GitHub actions for consistency and to be able to run on Windows. Added tests: - check that the extension description file name matches the project name in the CMakeLists.txt file - check that the extension can be git cloned - check that a license file can be found in the extension's repository - check that extension category is in the allowed list - check that the extension icon and screenshot URLs are valid image files Show repository URL, CMakeLists.txt, license file in a report in the pull request. This makes quick review of extension submissions a bit easier.
lassoan
force-pushed
the
add-more-automatic-tests
branch
from
9f8dce8 to
89ed9f1
Compare
Simplify maintenance by leveraging existing GitHub Actions to streamline the process avoiding the need to use custom scripting.
|
@lassoan Thanks for working on this 🙏 This will greatly improve the reviewer experience 💯 I added a few tweaks that should hopefully simplify the maintenance. Did you have a chance to test against a fork ? |
lassoan
commented
Aug 11, 2025
|
Thank you for the updates @jcfr. It seems that you have tried to enable commenting from a fork, but it does not appear to work (see the Extension Validation check failure above. The failing Lint check above is a good example that the json schema check still sometimes fails. It may be easier to just disable it, since the schema is checked in the Extension Validation check anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move filename checks from bash script executed by CircleCI to Python script executed by GitHub actions for consistency and to be able to run on Windows. Moved the unstable pre-commit json file schema check to the other extension validation checks.
Added tests:
CMakeLists.txtfileShow repository URL,
CMakeLists.txt, license file in a report in the pull request. This makes quick review of extension submissions a bit easier.