[skiplang/skstore] Fix locking in runWithGcIntern.
#702
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beauby
force-pushed
the
fix-runwithgc
branch
2 times, most recently
from
04ac522 to
fb085e2
Compare
mbouaziz
reviewed
Jan 31, 2025
Contributor
mbouaziz
left a comment
mbouaziz
left a comment
There was a problem hiding this comment.
There's a lot that could be factored in these 4 branches
Contributor
Author
Agreed. IIUC @skiplabsdaniel is working on cleaning up those APIs. The scope of this PR is only to fix the glaring bug. |
mbouaziz
approved these changes
Feb 6, 2025
skiplabsdaniel
approved these changes
Feb 6, 2025
When calling `runWithGc()` without a `synchronizer`, the global lock was released after each iteration, and never re-acquired.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When calling
runWithGc()without asynchronizer, the global lock was released after each iteration, and never re-acquired.The code path did not seem to be actively used, as it would systematically crash.