Skip to content

Conversation

@jberdine
Copy link
Contributor

No description provided.

@jberdine jberdine requested a review from bennostein January 15, 2025 16:27
@jberdine
Copy link
Contributor Author

I also noticed that parts of deploying.md are not in sync with the hackernews example, but the example code hasn't changed since the docs landed, so I guess that discrepancy is intended. E.g. backend skip vs backend stream in haproxy.cfg.

@jberdine jberdine merged commit a901b01 into main Jan 15, 2025
3 checks passed
@jberdine jberdine deleted the doc branch January 15, 2025 16:37
@bennostein
Copy link
Contributor

I also noticed that parts of deploying.md are not in sync with the hackernews example, but the example code hasn't changed since the docs landed, so I guess that discrepancy is intended. E.g. backend skip vs backend stream in haproxy.cfg.

Yes, I think that was intended at time of writing, under the logic that it would be clearer/easier to understand. But I'm not married to anything, feel free to change around as you see fit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants