Make resources field non-optional on SkipService
#561
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bennostein
force-pushed
the
nonoptional-resources
branch
from
aa7da32 to
104ddb4
Compare
jberdine
approved these changes
Nov 28, 2024
Contributor
jberdine
left a comment
jberdine
left a comment
There was a problem hiding this comment.
A service with no resources would have to be write-only, which I guess is enough of a special case to make users pass an empty dict or resources explicitly. :-)
beauby
approved these changes
Nov 29, 2024
bennostein
force-pushed
the
nonoptional-resources
branch
from
104ddb4 to
13a3865
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it says on the tin.
I noticed this while writing up resource/service docs, and couldn't think of any case where it makes sense to have a service with no output resources. Nor does any such case exist in our examples.