[skipruntime] Garbage collector and subscribe callbacks #546
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skiplabsdaniel
force-pushed
the
subscribe-callbacks
branch
3 times, most recently
from
25615ca to
6657909
Compare
Contributor
|
@beauby, do you think the compiler test failures look like just stale expected results for compiler errors after your change to add full paths to source locations? |
Contributor
Yes, exactly. |
skiplabsdaniel
force-pushed
the
subscribe-callbacks
branch
from
6657909 to
62112e4
Compare
beauby
approved these changes
Nov 28, 2024
| } | ||
|
|
||
| class Notifier(eptr: SKStore.ExternalPointer) { | ||
| class ExternNotifier(eptr: SKStore.ExternalPointer) extends Notifier { |
Contributor
There was a problem hiding this comment.
Suggested change
| class ExternNotifier(eptr: SKStore.ExternalPointer) extends Notifier { | |
| class ExternalNotifier(eptr: SKStore.ExternalPointer) extends Notifier { |
Contributor
Author
There was a problem hiding this comment.
I prefer to keep the naming consistent, if it has to be renamed it's better to do it in another PR by renaming all the other Extern.
| remoteCollections.each((_k, es) -> es.shutdown()); | ||
| }); | ||
| context.removePersistent(kRemoteSpecifiers); | ||
| context.update(); |
Contributor
There was a problem hiding this comment.
Was this update missing before?
skipruntime-ts/native/src/Runtime.sk
Outdated
| optRequest: ?Request, | ||
| ): GetResult<Values> { | ||
| resourceInstanceId = Ksuid::create().toString(); | ||
| //subscribe |
| context.sessions.maybeGet(session).each(sub -> { | ||
| close = sub.cmd match { | ||
| | SKStore.NWatch(_, _, _, close, _) -> close | ||
| | _ -> invariant_violation("Not manage session kind") |
Contributor
Author
There was a problem hiding this comment.
In theory, never
skiplabsdaniel
force-pushed
the
subscribe-callbacks
branch
2 times, most recently
from
7f2a6e5 to
eefa79c
Compare
skiplabsdaniel
force-pushed
the
subscribe-callbacks
branch
from
eefa79c to
06e6734
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.