Skip to content

Dedup definitions of TJSON type #440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Dedup definitions of TJSON type #440

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions skipruntime-ts/client/src/protocol.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,7 @@
// Interfaces

export interface JSONObject {
[key: string]: TJSON | null;
}
export type TJSON = number | JSONObject | boolean | (TJSON | null)[] | string;
import type { TJSON } from "skjson";
export type { JSONObject, TJSON } from "skjson";

export type Entry<K extends TJSON, V extends TJSON> = [K, V[]];

Expand Down
4 changes: 2 additions & 2 deletions skipruntime-ts/core/src/skipruntime_api.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@ import type { Constant } from "./internals/skipruntime_module.js";
* and values in the Skip Runtime, ensuring that they can be serialized and managed by the
* reactive computation engine.
*/
export type TJSON = number | boolean | string | JSONObject | (TJSON | null)[];
export type JSONObject = { [key: string]: TJSON | null };
import type { JSONObject, TJSON } from "skjson";
export type { JSONObject, TJSON } from "skjson";

/**
* A `Param` is a valid parameter to a Skip runtime mapper function: either a constant JS
Expand Down