- 
          
- 
                Notifications
    You must be signed in to change notification settings 
- Fork 888
V3 - Use BPP from Color Writer for Compressor #2915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    
                
     Merged
            
            
          Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the TIFF compressor initialization to use the computed BitsPerPixel from the color writer, ensuring parity between the compressor and the color writer. Key changes include:
- Defining a new test image constant for Issue2909.
- Adding new test cases for LZW and Deflate compression using the Issue2909 file.
- Updating the TiffEncoderCore to obtain BitsPerPixel from the color writer instead of from the encoder instance.
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description | 
|---|---|
| tests/ImageSharp.Tests/TestImages.cs | Added constant for Issue2909 test image. | 
| tests/ImageSharp.Tests/Formats/Tiff/TiffEncoderTests.cs | Added test cases for LZW and Deflate compression using Issue2909. | 
| src/ImageSharp/Formats/Tiff/TiffEncoderCore.cs | Changed compressor initialization to use colorWriter.BitsPerPixel. | 
Files not reviewed (1)
- tests/Images/Input/Tiff/Issues/Issue2909.tiff: Language not supported
  This was referenced Jul 28, 2025 
      
  This was referenced Sep 15, 2025 
      
  This was referenced Sep 24, 2025 
      
  This was referenced Oct 6, 2025 
      
  This was referenced Oct 13, 2025 
      
  This was referenced Oct 20, 2025 
      
  This was referenced Oct 29, 2025 
      
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Prerequisites
Description
Uses the computed
BitsPerPixelfrom the color writer instance for the compressor to ensure parity.Fixes #2909