-
-
Notifications
You must be signed in to change notification settings - Fork 888
V3 - Correctly handle transform spaces when building transform matrices. #2791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
This was referenced Aug 17, 2024
This was referenced Jul 30, 2025
This was referenced Jul 30, 2025
This was referenced Aug 17, 2025
This was referenced Sep 24, 2025
This was referenced Oct 13, 2025
This was referenced Oct 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
Fixes #2753
This is a rework of #2760 to correctly handle transforms that require working in the pixel transform space.
Previous attempts to fix these issues inadvertently introduced breaking changes for users who relied on the builder APIs to transform 2D paths. These changes affected how paths were handled, particularly in scenarios where the distinction between coordinate and pixel spaces wasn't explicitly managed. To mitigate this, the refactor introduces new configuration options within the builder APIs that allow users to specify which space (coordinate or pixel) they want to operate within. This ensures that developers can maintain control over how their transformations are applied, preserving existing workflows while also benefiting from the improved accuracy and flexibility of the new implementation. These options provide a smoother transition for users, allowing them to adapt to the changes without disrupting their existing codebases.
A little theory....
2D transforms take place in two different spaces:
Coordinate Space:
Pixel Space:
Key Changes in This Refactor:
Accurate Space Handling:
Inverted Scaled Offset:
Conditional Offset Application:
Improved Visual Accuracy: