-
-
Notifications
You must be signed in to change notification settings - Fork 887
Backport 2759 to 2.1.x #2770
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport 2759 to 2.1.x #2770
Conversation
Signed-off-by: antonfirsov <[email protected]>
Signed-off-by: antonfirsov <[email protected]>
JimBobSquarePants
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this!
I think incorporating the full decoder was probably wise here. There were likely other critical issues missed over time that should be included.
The jpeg issue in v3.1.x was that the chrominance quality was being determined as zero. This led to the encoder trying to divide by that value. I'm fine with decoder throwing an exception here.
Prerequisites
Description
Implemented it by a full port of 3.1.x Gif Decoder, so it contains improvements and behavioral changes made since then. It also decodes some stuff 2.1 API doesn't expose.
I didn't fully understand what was the JPEG change about, but the 2.1 decoder detects it as an invalid image. Added the test as a skipped test.