- 
                Notifications
    You must be signed in to change notification settings 
- Fork 70
Alternative proposal for "course" object in navigation #211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| Could you please add the nice example document, please? I can add the actual test then. | 
Originally by Fabian, small fixes & test added.
| The sample course data file uses  The other natural choice is to strip the resources section out of the test data file, making the test pass. Then this is mergable from my point of view and Great Circle equivalents can be added separately. | 
| This looks really good now and I am gradually getting use to the idea of having navigation.course and a parallel set of keys in navigation.courseGC I noticed that we are missing a timeToGo key in the navigation.course sub-group. This is different to ETA which is the estimated time that we arrive at the end of the route. Time to Go is the time in hours, mins, secs till we reach the next waypoint. | 
| I think we should remove the resources section as the navigaction.course group could be driven without any of the data from resources i.e. Just a go to position entered on a chart plotter app and the position of the boat when the go to was started. | 
| The resources data in the test file looked pretty good what needs to be done to get this in to the schema? | 
| I removed the resources section as it can be handled separately and we can get this merged. The notification part needs a bit more work, the test is failing because of  | 
This PR contains an alternative to #168. The
courseobject is simpler, containing just the information required to navigate to the next Point in the currently active course. Each point can (optionally) reference an object under resources, such as a waypoint.Some notes (related to a discussion on Slack):
previousPointinstead oflastPoint, as I felt thatlastPointcould be interpreted wrongly as "the last point of the route".hrefinstead ofidfor referencing other objects, as it's much less ambiguous