Api 6718 removed deprecated field #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
echumak-sift,
negupta72,
sbogolii-sift and
vincent-sift
sbogolii-sift
suggested changes
Aug 23, 2022
sbogolii-sift
approved these changes
Aug 23, 2022
| # pragma mark - Configuration | ||
|
|
||
| RCT_EXPORT_METHOD(setSiftConfig:(NSString *)accountId beaconKey:(NSString *)beaconKey disallowCollectingLocationData: (BOOL)disallowCollectingLocationData serverUrlFormat:(NSString *)serverUrlFormat allowUsingMotionSensors: (BOOL)allowUsingMotionSensors) { | ||
| Sift *sift = [Sift sharedInstance]; |
Contributor
There was a problem hiding this comment.
This line deletion breaks iOS compilation. Fixed: #13
jageet
added a commit
to SanoopC/sift-react-native
that referenced
this pull request
Nov 29, 2022
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as SiftScience/sift-ios@2bd062e
was merged we have to delete those fields in react native sdk as well