Verification endpoints implemented #96
Conversation
| ``` | ||
|
|
||
| # The send call triggers the generation of a OTP code that is stored by Sift and email/sms the code to the user. | ||
| send_properties = { |
There was a problem hiding this comment.
Can we also have site_country in the example payload?
Property description updated Co-authored-by: Mark Lunney <[email protected]>
1. Removed compatibility checking for python 2 2. "$site_country" property is added in payload
tests/test_verification_apis.py
Outdated
| "$verification_type": "$email", | ||
| "$brand_name": "MyTopBrand", | ||
| "$language": "en", | ||
| "$site_country": "Country Name", |
There was a problem hiding this comment.
Any string value will technically be accepted by our API but it will be treated as null if it's invalid. What we really expect here is a 2 character country code in upper case. Can you pick your favorite country and use it's code as the example?
From our documentation:
$site_country
String
Country the company is providing service from. Use ISO-3166 country code.
There was a problem hiding this comment.
@mlunney good point. Btw, We also noticed that in our public docs there is nothing mentioned about ISO country code for site_country field in Verification API section. Makes sense to add this to the docs
README.md
Outdated
| "$verification_type": "$email", | ||
| "$brand_name": "MyTopBrand", | ||
| "$language": "en", | ||
| "$site_country": "Country Name", |
There was a problem hiding this comment.
See other comment about the value for $site_country
Co-authored-by: Max Goeb <[email protected]>
4 participants
Purpose
The verification APIs are implemented (send/resend/check)
Summary
Added wrappers for the following APIs
Testing
Changes covered in Unit Test for the above API wrappers(path/tests/test_verification_apis.py)
verification/send (Real Call)
verification/resend
verification/check
Checklist