Skip to content

Conversation

mlhamel
Copy link
Contributor

@mlhamel mlhamel commented Apr 18, 2018

Make things easier for developing

@mlhamel mlhamel requested a review from pior April 18, 2018 16:06
dev.yml Outdated
commands:
lint:
desc: "Check for Python style & syntax errors in all Python files"
run: pylint --rcfile=pylintrc shopify_python tests setup.py
Copy link
Member

@pior pior Apr 19, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the Makefile it's only tests.shopify_python.
The tests.functional module is intentionally full of errors.

@mlhamel
Copy link
Contributor Author

mlhamel commented May 1, 2018

We could decide to completely dump the Makefile and only use dev but ...

Copy link
Member

@pior pior left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's start with this.

@mlhamel mlhamel merged commit 16c650c into master May 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants