Skip to content

Always specify a valid constant for Symbol kind #3596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Always specify a valid constant for Symbol kind #3596

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions lib/ruby_lsp/requests/support/common.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,6 +155,10 @@ def kind_for_entry(entry)
Constant::SymbolKind::PROPERTY
when RubyIndexer::Entry::InstanceVariable
Constant::SymbolKind::FIELD
when RubyIndexer::Entry::GlobalVariable
Constant::SymbolKind::VARIABLE
else
Constant::SymbolKind::NULL
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Constant::SymbolKind::NULL
$stderr.puts("Unknown symbol kind for #{entry.class}. Please report this as a bug")
Constant::SymbolKind::NULL

end
end
end
Expand Down