fix(🤖): fix thread issue with notifyTaskReadyExternal (#3547) #3548
+3
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This can be called from non-Java threads (e.g. Hermes "hades" GC thread) via Recorder::~Recorder -> runTaskOnMainThread(). We must ensure the current thread is attached to the JVM before using fbjni / Java refs.
Contributor
Author
|
I have signed the CLA! |
Contributor
|
super nice catch, I feel silly that I missed it. |
wcandillon
approved these changes
Nov 19, 2025
Contributor
|
🎉 This PR is included in version 2.3.14 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've had a bunch of crashing and this definitely resolved it :)
Thanks for the great library and I'm glad I could contribute something back
The issue is: this can be called from non-Java threads (e.g. Hermes "hades" GC thread) via Recorder::~Recorder -> runTaskOnMainThread(). We must ensure the current thread is attached to the JVM before using fbjni / Java refs.