Internalize [2 of 4] #18
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
g-Off
approved these changes
Sep 11, 2017
|
Build failures look legit 😕 |
g-Off
suggested changes
Sep 12, 2017
| public let data: DataType? | ||
| public let errors: [GraphQL.ResponseError]? | ||
| internal let data: DataType? | ||
| internal let errors: [GraphQL.ResponseError]? |
There was a problem hiding this comment.
these should be left public, they are the purpose of this struct (deserializing response into errors/data)
There was a problem hiding this comment.
They aren't needed on any of the generated models.
There was a problem hiding this comment.
They are/can be used by external code though. From the README
guard let response = try? GraphQLResponse<ExampleSchema.QueryRoot>(jsonData: response) else {
print("Invalid GraphQL response")
return
}
if let errors = response.errors {
for error in errors {
print("GraphQL error: \(error.message)")
}
}
if let data = response.data {
let user = data.user
print("\(user.firstName) \(user.lastName)")
}There was a problem hiding this comment.
What is GraphQLResponse used for? I can't find any usage of it. Can we not just remove it entirely?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this does
Coverts unnecessarily
publicmethods tointernal.Relies on #13