Wrap Module V2 #123
Merged
Wrap Module V2 #123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Looks pretty good. Used this diff checker to compare to previous version contracts
contracts/protocol/integration/wrap-v2/CompoundWrapV2Adapter.sol
Outdated
Show resolved
Hide resolved
richardliang
approved these changes
Aug 13, 2021
richardliang
pushed a commit
that referenced
this pull request
Aug 25, 2021
* add WrapModuleV2 * add deploys * add integration tests for WrapModuleV2 * add compound wrap adapter * add yearn wrap adapter * add approval on unwrap * review fixes * add comment about why we approve on unwrap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
STIP: SetProtocol/STIPS#7
I also updated the Yearn and Compound wrap adapters to work with the new module. Decided against updating the Aave V1 wrap adapter since that market has basically been deprecated.