This repository was archived by the owner on Mar 27, 2023. It is now read-only.
Allowing clients to set connection timeouts. #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
constructors later.
underlying HttpURLConnection object. Using new ConnectionProperties class so that additional properties might be added later without requiring changed/new constructors.
connection properties there.
makes the defaults clearer. Also fixes bug wherein connection properties weren't being given a default value when using the existing constructors.
this was resulting in an NPE instead as the exception handler attempted to process the request anyway).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #8
Backward compatibility: clients using the existing constructors would see no change; the default timeout is no-timeout, and that is preserved via the default options via
new ConnectionProperties()in those constructors.Note: If a client does explicitly set timeouts via the new construtors, a timeout will result in a
java.net.SocketTimeoutExceptionpropagating up to the client code, not the existingIOExceptionhandler which processes the error stream (there wouldn't be one in the case of a socket timeout, and so this code would result in an NPE)