Skip to content

fix(Ref) Add a workaround for findDomNode to work with React 16.6.0 #3258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix(Ref) Add a workaround for findDomNode to work with React 16.6.0 #3258

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/addons/Ref/Ref.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,11 @@ export default class Ref extends Component {

// Heads up! Don't move this condition, it's a short circuit that avoids run of `findDOMNode`
// if `innerRef` isn't passed
// eslint-disable-next-line react/no-find-dom-node
if (innerRef) innerRef(findDOMNode(this))
try {
// eslint-disable-next-line react/no-find-dom-node
if (innerRef) innerRef(findDOMNode(this))
// eslint-disable-next-line no-empty
} catch (_) {}
Copy link
Author

@laplacesdemon laplacesdemon Nov 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Silencing the error is horrible and I'm really not happy with this line. There are 2 options: either report it with console.error which will pollute the unit test runs, or only do a try catch in development environment (i.e. check for process.env.NODE_ENV === 'development). What do you think?

Copy link
Member

@levithomason levithomason Nov 30, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@layershifter Given your updates in Stardust, what's your thought here?

Copy link
Member

@layershifter layershifter Nov 30, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will backport changes from microsoft/fluent-ui-react#491, this will resolve this issue fully 👍

Copy link
Author

@laplacesdemon laplacesdemon Dec 11, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing this issue.

}

render() {
Expand Down