Skip to content

Conversation

@diemol
Copy link
Member

@diemol diemol commented Apr 16, 2024

User description

Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to review and merge it quickly

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, and help reviewers by making them as simple and short as possible.

Description

Motivation and Context

Types of changes

  • Change to the site (I have double-checked the Netlify deployment, and my changes look good)
  • Code example added (and I also added the example to all translated languages)
  • Improved translation
  • Added new translation (and I also added a notice to each document missing translation)

Checklist

  • I have read the contributing document.
  • I have used hugo to render the site/docs locally and I am sure it works.

Type

enhancement


Description

  • Added Bright Data as a new sponsor in the sponsors.yml file, including their logo, URL, and the sponsorship start date.

Changes walkthrough

Relevant files
Enhancement
sponsors.yml
Add Bright Data as a New Selenium Sponsor                               

website_and_docs/data/sponsors.yml

  • Added Bright Data as a new sponsor with logo, URL, and name.
  • Included sponsorship start date for Bright Data.
  • +4/-0     

    PR-Agent usage:
    Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

    @qodo-merge-pro qodo-merge-pro bot added the enhancement New feature or request label Apr 16, 2024
    @qodo-merge-pro
    Copy link
    Contributor

    PR Description updated to latest commit (82a3197)

    @qodo-merge-pro
    Copy link
    Contributor

    PR Review

    ⏱️ Estimated effort to review [1-5]

    1, because the changes are straightforward and involve adding a new sponsor to an existing YAML file. The addition follows the existing structure and format used for other sponsors, making it easy to review.

    🧪 Relevant tests

    No

    🔍 Possible issues

    No

    🔒 Security concerns

    No


    ✨ Review tool usage guide:

    Overview:
    The review tool scans the PR code changes, and generates a PR review which includes several types of feedbacks, such as possible PR issues, security threats and relevant test in the PR. More feedbacks can be added by configuring the tool.

    The tool can be triggered automatically every time a new PR is opened, or can be invoked manually by commenting on any PR.

    • When commenting, to edit configurations related to the review tool (pr_reviewer section), use the following template:
    /review --pr_reviewer.some_config1=... --pr_reviewer.some_config2=...
    
    [pr_reviewer]
    some_config1=...
    some_config2=...
    

    See the review usage page for a comprehensive guide on using this tool.

    @qodo-merge-pro
    Copy link
    Contributor

    PR Code Suggestions

    CategorySuggestions                                                                                                                                                       
    Enhancement
    Verify and adjust URL tracking parameters for effectiveness.

    Ensure that the URL parameters for tracking (utm_source, utm_campaign, etc.) are correctly
    set up and match the intended tracking strategy. This will help in accurately measuring
    the effectiveness of the sponsorship and the traffic it generates.

    website_and_docs/data/sponsors.yml [7]

    -url: "https://brightdata.com/?utm_source=brand&utm_campaign=brnd-mkt_partners_selenium"
    +url: "https://brightdata.com/?utm_source=selenium_sponsor&utm_campaign=bright_data_sponsorship"
     
    Maintainability
    Add an end date for the sponsorship for better management.

    Add an explicit end date for the sponsorship if available. This helps in keeping the
    sponsorship information up-to-date and makes it easier to manage sponsorships over time.

    website_and_docs/data/sponsors.yml [5]

     # Sponsorship start date: April 16, 2024
    +# Sponsorship end date: [Insert End Date Here]
     

    ✨ Improve tool usage guide:

    Overview:
    The improve tool scans the PR code changes, and automatically generates suggestions for improving the PR code. The tool can be triggered automatically every time a new PR is opened, or can be invoked manually by commenting on a PR.

    • When commenting, to edit configurations related to the improve tool (pr_code_suggestions section), use the following template:
    /improve --pr_code_suggestions.some_config1=... --pr_code_suggestions.some_config2=...
    
    [pr_code_suggestions]
    some_config1=...
    some_config2=...
    

    See the improve usage page for a comprehensive guide on using this tool.

    @github-actions
    Copy link
    Contributor

    Images automagically compressed by Calibre's image-actions

    Compression reduced images by 9%, saving 2.00 KB.

    Filename Before After Improvement Visual comparison
    website_and_docs/static/images/sponsors/bright-data.png 22.19 KB 20.18 KB -9.0% View diff

    113 images did not require optimisation.

    @netlify
    Copy link

    netlify bot commented Apr 16, 2024

    Deploy Preview for selenium-dev ready!

    Name Link
    🔨 Latest commit 82a3197
    🔍 Latest deploy log https://app.netlify.com/sites/selenium-dev/deploys/661e80b4e49ce40008f88d2f
    😎 Deploy Preview https://deploy-preview-1674--selenium-dev.netlify.app
    📱 Preview on mobile
    Toggle QR Code...

    QR Code

    Use your smartphone camera to open QR code link.

    To edit notification comments on pull requests, go to your Netlify site configuration.

    @netlify
    Copy link

    netlify bot commented Apr 16, 2024

    Deploy Preview for selenium-dev ready!

    Name Link
    🔨 Latest commit 110d128
    🔍 Latest deploy log https://app.netlify.com/sites/selenium-dev/deploys/661e80ed3f876200083c6d87
    😎 Deploy Preview https://deploy-preview-1674--selenium-dev.netlify.app
    📱 Preview on mobile
    Toggle QR Code...

    QR Code

    Use your smartphone camera to open QR code link.

    To edit notification comments on pull requests, go to your Netlify site configuration.

    @diemol diemol merged commit 8440f42 into trunk Apr 16, 2024
    @diemol diemol deleted the bright_data branch April 16, 2024 13:49
    selenium-ci added a commit that referenced this pull request Apr 16, 2024
    * Adding Bright Data as Selenium sponsor
    
    * Optimised images with calibre/image-actions
    
    ---------
    
    Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
    
    [deploy site] 8440f42
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Labels

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    2 participants