Skip to content

Conversation

@titusfortner
Copy link
Member

@titusfortner titusfortner commented Nov 17, 2023

Description

Based on the new tab pane code (#1529 needs to be merged first)...

  1. This allows us to set the active tab from the URL again:
    https://selenium.dev/documentation/webdriver/actions_api/mouse/?tab=ruby#forward-click

  2. This sets the tab height the same across each pane.

Motivation and Context

  • When linking to something in our docs, it would be nice to send users to the language directly
  • It is really difficult to switch between tabs when the whole page resizes

@netlify
Copy link

netlify bot commented Nov 17, 2023

Deploy Preview for selenium-dev ready!

Name Link
🔨 Latest commit 105ead0
🔍 Latest deploy log https://app.netlify.com/sites/selenium-dev/deploys/655e2d2da9813b000817ea4a
😎 Deploy Preview https://deploy-preview-1530--selenium-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@titusfortner
Copy link
Member Author

@diemol I think this is good to update.
I've PR'd both of these to Docsy, and they are looking into them for Q1: google/docsy#1746
When they merge and release, we can update module version and delete this file.

@diemol diemol merged commit e954534 into trunk Nov 22, 2023
@diemol diemol deleted the pane_updates branch November 22, 2023 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants